[DOCS] Adding keys to duplicated headers #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10846 +/- ##
========================================
Coverage 80.69% 80.69%
========================================
Files 465 465
Lines 40493 40493
========================================
Hits 32676 32676
Misses 7817 7817 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deborahniesz
force-pushed
the
DOC-914_deleting_duplicate_IDs_in_anchors
branch
from
118c706 to
cc35b32
Compare
josectobar
approved these changes
Jan 13, 2025
deborahniesz
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
deborahniesz
force-pushed
the
DOC-914_deleting_duplicate_IDs_in_anchors
branch
from
fb6e61b to
879e151
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nicgrayson
added a commit
that referenced
this pull request
Jan 27, 2025
* origin/develop: (102 commits) [DOCS] restore lychee (#10889) [RELEASE] 1.3.3 (#10888) [DOCS] add migration guide to 0.18 docs (#10885) [MAINTENANCE] Migrate from `databricks-sql-connector` to `databricks-sqlalchemy` in tests (#10886) [BUGFIX] Allow adding Expectations with identical attributes to Suites (#10884) [DOCS] Corrections and clarifications for result_format (#10875) [BUGFIX] Make validation results' describe_dict return a serializable dict (#10863) [MAINTENANCE] Convert BatchTestSetup.asset property to BatchTestSetup… (#10864) [MAINTENANCE] Add method to set analytics user_agent_str (#10883) [DOCS] Update documentation around batch_parameters and link to updated API docs. (#10877) [MAINTENANCE] Add user-agent-str to analytics events (#10869) [RELEASE] 1.3.2 (#10874) [DOCS] Add titles to properties and methods sections in API Reference (#10821) [MAINTENANCE] Handle `aws-chunked` encoding type data in `TupleS3StoreBackend` (#10861) [Docs] update screenshot of observed value (#10867) [MAINTENANCE] Enforce a minimum length of 2 for MulticolumnMapExpectation `column_list` (#10850) [BUGFIX] Add input args validators to various Expectations (#10833) [DOCS] fix custom SQL Expectation approach for cloud (#10844) [FEATURE] Enable strict_min/max for ExpectTableRowCountToBeBetween (#10845) [DOCS] Adding keys to duplicated headers (#10846) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
Deploy Preview
Description
Added specific ID's to duplicated titles in h2 and h3 anchors to avoid the following problem:
repeated headers result in duplicate IDs which make anchors not work as expected
Steps to reproduce:
Go to Connect to SQL data | Great Expectations
Under "Create a Data Asset", next to "Procedure", click the # direct link
Observe that this jumps you up to the "Procedure" section that's nested under "configure credentials" instead of keeping you at the "Procedure" section that's nested under "Create a Data Asset"
invoke lint(usesruff format+ruff check)For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!